Add service name to error message to more easily pinpoint service nam… #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e clashes in HAP-nodejs
donavanbecker
approved these changes
Jun 24, 2024
Supereg
approved these changes
Jun 24, 2024
Pull Request Test Coverage Report for Build 9636221085Details
💛 - Coveralls |
donavanbecker
added a commit
that referenced
this pull request
Jun 24, 2024
## v3.7.3 (2024-06-24) ### Other Changes - Add service name to error message to more easily pinpoint service name (#22) (@slyoldfox)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e clashes in HAP-nodejs
♻️ Current situation
It can get quite annoying to pinpoint which Service is causing Homebridge or HAP-nodejs to fail (in my case it was due to the same service being used in DEV as the service being used by my intercom).
💡 Proposed solution
Add the name of the service to the Error to more clearly reflect which Service needs to be reconfigured.
⚙️ Release Notes
Provide a summary of the changes or features from a user's point of view. If there are breaking changes, provide migration guides using code examples of the affected features.
➕ Additional Information
If applicable, provide additional context in this section.
Testing
Which tests were added? Which existing tests were adapted/changed? Which situations are covered, and what edge cases are missing?
Reviewer Nudging
Where should the reviewer start? what is a good entry point?