Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add questdb python client #705

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

diferhe
Copy link

@diferhe diferhe commented Sep 14, 2024

Add questdb python client (repo) required by QSS custom integration. The upstream doesn't provide wheels for musl linux armv7.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @diferhe

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft September 14, 2024 12:06
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@cdce8p
Copy link
Member

cdce8p commented Dec 8, 2024

Ref: home-assistant/core#132398
/CC @joostlek

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We like to avoid creating/hosting wheels in case project can provide them themselves.

Did you contact the upstream project to see if they want to add support for it? Alternative, you could maybe contribute the addition upstream?

The reason we like to push for this route, it that such changes benefit not just Home Assistant, but the entire Python ecosystem.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft December 9, 2024 07:51
@antst
Copy link

antst commented Dec 10, 2024

We like to avoid creating/hosting wheels in case project can provide them themselves.

Did you contact the upstream project to see if they want to add support for it? Alternative, you could maybe contribute the addition upstream?

The reason we like to push for this route, it that such changes benefit not just Home Assistant, but the entire Python ecosystem.

../Frenck

I did contact them 5 days ago (as I agree that it is better if it is provided by them), but no reply so far. Going through their issue tracker history, I don't have a lot of hope there :)

@antst
Copy link

antst commented Dec 11, 2024

BTW, if I see it right, this PR is not enough. There is also need to add extra apk ("cargo") to the list of apks in GitHub action. To build this wheel one need to have installed rust compiler, as it is written mostly in rust.

And important to note that this is not anymore issue of armv7, but issue on all platforms.

@cdce8p
Copy link
Member

cdce8p commented Dec 11, 2024

BTW, if I see it right, this PR is not enough. There is also need to add extra apk ("cargo") to the list of apks in GitHub action. To build this wheel one need to have installed rust compiler, as it is written mostly in rust.

The wheel builder includes rust / cargo. So that should work out of the box.
https://github.com/home-assistant/wheels?tab=readme-ov-file#platform-tags

@antst
Copy link

antst commented Dec 18, 2024

So, what do we do next?
Upstream is not responding to request to provide binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants