-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add questdb python client #705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Ref: home-assistant/core#132398 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We like to avoid creating/hosting wheels in case project can provide them themselves.
Did you contact the upstream project to see if they want to add support for it? Alternative, you could maybe contribute the addition upstream?
The reason we like to push for this route, it that such changes benefit not just Home Assistant, but the entire Python ecosystem.
../Frenck
I did contact them 5 days ago (as I agree that it is better if it is provided by them), but no reply so far. Going through their issue tracker history, I don't have a lot of hope there :) |
BTW, if I see it right, this PR is not enough. There is also need to add extra apk ("cargo") to the list of apks in GitHub action. To build this wheel one need to have installed rust compiler, as it is written mostly in rust. And important to note that this is not anymore issue of armv7, but issue on all platforms. |
The wheel builder includes rust / cargo. So that should work out of the box. |
So, what do we do next? |
Frenck, |
ping... |
@frenck Can you clarify, what is deal breaker now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If upstream still hasn't handled it, I guess it is fine to move forward on our end for the time being.
Thanks for you patience on this one @diferhe 👍
../Frenck
Thanks! |
Add questdb python client (repo) required by QSS custom integration. The upstream doesn't provide wheels for musl linux armv7.