Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove timeout on validate for docker #3505

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Remove timeout on validate for docker #3505

merged 1 commit into from
Mar 10, 2022

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Mar 10, 2022 •
edited
Loading

Proposed change

Let that handle on the upper layer, as we not handle any timeout exception on that level.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@pvizeli pvizeli added the bugfix A bug fix label Mar 10, 2022
@pvizeli pvizeli merged commit 45e54d9 into main Mar 10, 2022
@pvizeli pvizeli deleted the fix-timeout-issue branch March 10, 2022 13:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
bugfix A bug fix cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvizeli @frenck @homeassistant