Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filtering with docker 20.10.x #2371

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Fix filtering with docker 20.10.x #2371

merged 2 commits into from
Dec 15, 2020

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Dec 15, 2020 •
edited
Loading

Proposed change

Pin docker-py to this commit which fixes the filtering after Docker 20.10

docker/docker-py@1757c97

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@ludeeus ludeeus added the bugfix A bug fix label Dec 15, 2020
@pvizeli pvizeli merged commit 0989ee8 into main Dec 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the docker-py branch December 15, 2020 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
bugfix A bug fix cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supervised installation not working on Docker 20.x
3 participants
@ludeeus @pvizeli @homeassistant