Pin awscli to older version to work around R2 issues #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI job fails to upload build artifacts because R2 doesn't support checksums [1]. This was added in awscli 1.37.0 [2], pin to a version older than that to work around the issue before R2 supports it or ignores the header. [1] https://www.cloudflarestatus.com/incidents/t5nrjmpxc1cj [2] https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst
📝 WalkthroughWalkthroughThe pull request modifies the GitHub Actions workflow configuration, specifically targeting the AWS CLI installation step. The change introduces a version constraint for the AWS CLI, limiting its installation to versions below 1.37.0. This modification suggests a potential compatibility concern or a deliberate restriction on the AWS CLI version used in the build process. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build.yaml (1)
202-202: LGTM! Consider adding a comment explaining the version constraint.The version constraint is correct and effectively works around the R2 checksum compatibility issue. However, since this is a temporary workaround, it would be helpful to:
- Add a comment explaining why this version is pinned
- Create an issue to track when this constraint can be removed (once R2 supports checksums)
Add a comment above the pip install:
+ # Pin awscli version due to R2 not supporting checksums (introduced in 1.37.0) run: pip install 'awscli<1.37.0'
agners
approved these changes
Jan 17, 2025
|
Is there R2 specific tooling we could maybe use? 🤔 |
sairon
added a commit
that referenced
this pull request
Jan 17, 2025
Similarly to #3803, artifact index update fails because the R2 doesn't like the new awscli. The regression apparently comes from 1.37.0 as well, so pin to version older than that.
sairon
added a commit
that referenced
this pull request
Jan 17, 2025
Similarly to #3803, artifact index update fails because the R2 doesn't like the new awscli. The regression apparently comes from 1.37.0 as well, so pin to version older than that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI job fails to upload build artifacts because R2 doesn't support checksums [1]. This was added in awscli 1.37.0 [2], pin to a version older than that to work around the issue before R2 supports it or ignores the header.
[1] https://www.cloudflarestatus.com/incidents/t5nrjmpxc1cj
[2] https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst
Summary by CodeRabbit