Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Yellow's post-install hook for config.txt migration #3671

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

sairon
Copy link
Member

@sairon sairon commented Nov 14, 2024

The hook was missing in the manifest, enable it conditionally for Yellow and add reminder to remove it once it's not needed.

Summary by CodeRabbit

  • New Features
    • Enhanced conditional logic in the OTA manifest for improved hook handling based on environment variables.
  • Documentation
    • Expanded comments in the rauc-hook script for clarity on requirements related to CM5 support for the Yellow system.

The hook was missing in the manifest, enable it conditionally for Yellow and
add reminder to remove it once it's not needed.
@sairon sairon added the board/yellow Home Assistant Yellow label Nov 14, 2024
@sairon sairon requested a review from agners November 14, 2024 08:42
@sairon sairon merged commit 9dfbdd9 into dev Nov 14, 2024
2 of 3 checks passed
@sairon sairon deleted the fix-yellow-post-install-hook branch November 14, 2024 08:44
Copy link

coderabbitai bot commented Nov 14, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes introduced in this pull request involve modifications to the manifest.raucm.gtpl file and the rauc-hook script. In the manifest.raucm.gtpl, conditional logic is added to the [image.boot] and [image.kernel] sections to adjust the hooks attribute based on specific environment variables. The rauc-hook script has updated comments in the post_install_boot function to clarify dependencies related to the manifest.raucm.gtpl, although the core functionality remains unchanged.

Changes

File Path Change Summary
buildroot-external/ota/manifest.raucm.gtpl Added conditional logic for hooks in [image.boot] and [image.kernel] sections based on environment variables.
buildroot-external/ota/rauc-hook Updated comments in post_install_boot function for clarity regarding manifest.raucm.gtpl dependency. No functional changes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant System
    participant Manifest

    User->>System: Trigger installation
    System->>Manifest: Check environment variables
    alt ota_compatible == "haos-yellow"
        Manifest-->>System: Set hooks to install;post-install;
    else
        Manifest-->>System: Set hooks to install;
    end
    alt BOOTLOADER == "grub" or "tryboot"
        Manifest-->>System: Set hooks to post-install;
    end
    System->>User: Installation complete
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sairon sairon mentioned this pull request Nov 19, 2024
@sairon sairon mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board/yellow Home Assistant Yellow cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants