-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Yellow's post-install hook for config.txt migration #3671
Conversation
The hook was missing in the manifest, enable it conditionally for Yellow and add reminder to remove it once it's not needed.
Caution Review failedThe pull request is closed. 📝 Walkthrough📝 WalkthroughWalkthroughThe changes introduced in this pull request involve modifications to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant System
participant Manifest
User->>System: Trigger installation
System->>Manifest: Check environment variables
alt ota_compatible == "haos-yellow"
Manifest-->>System: Set hooks to install;post-install;
else
Manifest-->>System: Set hooks to install;
end
alt BOOTLOADER == "grub" or "tryboot"
Manifest-->>System: Set hooks to post-install;
end
System->>User: Installation complete
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The hook was missing in the manifest, enable it conditionally for Yellow and add reminder to remove it once it's not needed.
Summary by CodeRabbit
rauc-hook
script for clarity on requirements related to CM5 support for the Yellow system.