Reduce timeout for network time synchronization to 15 seconds #3669
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout of 90s was introduced before it was ensured that the timesync systemd unit starts after network is online. Now with that, it makes less sense to wait that long - if network is unreachable at the point the time synchronization starts, and the server fails to reply on the first sync, the polling interval is exponentially increased and the benefit of waiting for more attempts is doubtful. Since another synchronization attempt is done after network changes its state, we should rely on that instead of having the 90 seconds interval as a waiting period for plugging the network cable. Worst case, there are other mechanisms that should set the time to a reasonably accurate value, making the NTP sync less importart for most of the cases.
📝 WalkthroughWalkthroughThe changes involve a modification to the configuration of the Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)buildroot-external/rootfs-overlay/usr/lib/systemd/system/systemd-time-wait-sync.service.d/timeout.conf (1)
The reduction from 90s to 15s is reasonable given that:
Let's verify the service dependencies and behavior: Consider monitoring the following metrics after deployment:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
agners
approved these changes
Nov 13, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout of 90s was introduced before it was ensured that the timesync systemd unit starts after network is online. Now with that, it makes less sense to wait that long - if network is unreachable at the point the time synchronization starts, and the server fails to reply on the first sync, the polling interval is exponentially increased and the benefit of waiting for more attempts is doubtful.
Since another synchronization attempt is done after network changes its state, we should rely on that instead of having the 90 seconds interval as a waiting period for plugging the network cable. Worst case, there are other mechanisms that should set the time to a reasonably accurate value, making the NTP sync less importart for most of the cases.
Summary by CodeRabbit