Reduce log spam from Docker health checks #3491
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce verbosity from deactivated Docker mounts, triggered by the Docker healthcheck. These messages do not carry any value for us and logs supplied by users are often spammed mostly with these. Moreover, they sometimes cause confusion that something is wrong, see for example #3021. Unfortunately, it's not possible to use LogFilterPatterns= here, because it's not applied to these messages, as explicitly said in the docs: Filtering is based on the unit for which LogFilterPatterns= is defined meaning log messages coming from systemd(1) about the unit are not taken into account. runc 1.2.0 supposedly should fix this, but it's unclear when it would be available, so let's stick to this solution (reducing verbosity from debug to notice for all units `run-docker-*.mount`) for the time being.
sairon
force-pushed
the
reduce-docker-healthcheck-logspam
branch
from
c93de6e to
27e09b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce verbosity from deactivated Docker mounts, triggered by the Docker healthcheck. These messages do not carry any value for us and logs supplied by users are often spammed mostly with these. Moreover, they sometimes cause confusion that something is wrong, see for example #3021.
Unfortunately, it's not possible to use LogFilterPatterns= here, because it's not applied to these messages, as explicitly said in the docs:
runc 1.2.0 supposedly should fix this, but it's unclear when it would be available, so let's stick to this solution (reducing verbosity from debug to notice for all units
run-docker-*.mount) for the time being.