Use Genimage for declarative image layout #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agners
reviewed
May 23, 2024
There was a problem hiding this comment.
The whole PR looks very good 🤩
There are probably simplification opportunities, especially in the SPL/boot part of things.
But transitioning what we have to genimage first is a good approach. We can then still start to optimize/change things in future steps 👍
buildroot-external/board/hardkernel/odroid-c4/partition-spl-spl.cfg
Outdated
Show resolved
Hide resolved
buildroot-external/board/hardkernel/odroid-n2/partition-spl-spl.cfg
Outdated
Show resolved
Hide resolved
buildroot-external/board/hardkernel/odroid-xu4/partition-spl-spl.cfg
Outdated
Show resolved
Hide resolved
agners
reviewed
May 23, 2024
agners
approved these changes
May 23, 2024
|
With changes from pengutronix/genimage#248, we should be able to achieve the same MBR layout as we used previously. |
This is what it really is, so just make sure only one "fix" function is called.
There is no reason to have separate efi and boot sys, since all boards that use efi also use grub as the loader.
Current implementation is mostly working, the only current problem seems
to be the MBR layout which is not possible to be achieved with current
Genimage capabilities. So far there are three places where this can cause
problems:
1. The partition resizing service/script can't resize the data
partition, because the extended partition needs to be resized first.
2. Partition numbers in mbr.rules do not match.
3. U-Boot scripts use partition numbers instead of labels.
|
Okay, I think this is ready for the final review. I ran a test build with modified job definition to compare partition tables and layout of the generated image when an SPL is present. There are couple of differences but IMO none of them should break anything, or they even straighten some things. In summary:
tl;dr - we don't have binary-identical images but functionally there shouldn't be differences. We still should test all the boards (or at least those that have some specifics) - but I have tried on those I have available and things are looking good. |
agners
reviewed
Jun 7, 2024
Merged
sairon
added a commit
that referenced
this pull request
Jul 29, 2024
…sues Genimage sets the first usable LBA to the offset of the first partition. While it shouldn't be an issue in theory, Windows may do some nasty things with the GPT header afterwards which breaks the Raspberry Pi bootloader, manifesting as Before purpose of this behavior is clarified in [1], add a downstream patch that sets the first usable LBA back to 34, which was the value that was used before migrating to Genimage in #3388. Since changing this value (hopefully) doesn't have any other consequences, and the images now should be closer to pre-genimage builds, no more side-effects are expected from this change. [1] https://www.github.com/pengutronix/genimage/issues/262 Fixes #3437
sairon
added a commit
that referenced
this pull request
Jul 30, 2024
…sues (#3497) Genimage sets the first usable LBA to the offset of the first partition. While it shouldn't be an issue in theory, Windows may do some nasty things with the GPT header afterwards which breaks the Raspberry Pi bootloader, manifesting as Before purpose of this behavior is clarified in [1], add a downstream patch that sets the first usable LBA back to 34, which was the value that was used before migrating to Genimage in #3388. Since changing this value (hopefully) doesn't have any other consequences, and the images now should be closer to pre-genimage builds, no more side-effects are expected from this change. [1] https://www.github.com/pengutronix/genimage/issues/262 Fixes #3437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.