Ignore non-existing CP15 barrier instructions emulation #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CP15 barrier instruction emulation only exists on arm64 architecture. Avoid sysctl writing an error to the journal when the setting doesn't exist by prepending a dash.
sairon
approved these changes
Apr 3, 2024
jens-maus
added a commit
to jens-maus/RaspberryMatic
that referenced
this pull request
Apr 7, 2024
sairon
pushed a commit
that referenced
this pull request
Apr 8, 2024
CP15 barrier instruction emulation only exists on arm64 architecture. Avoid sysctl writing an error to the journal when the setting doesn't exist by prepending a dash. (cherry picked from commit 889b561)
jens-maus
added a commit
to jens-maus/RaspberryMatic
that referenced
this pull request
Jun 18, 2024
this sysctl statement is used. This reverts the changes proposed by home-assistant/operating-system#3285
|
@agners Sorry, to bring back this already merged PR, but after I applied this change (add '-' to mitigate warning) my users are reporting that the |
|
@jens-maus I remember I tested it, but was now a bit perplex when i realized that Busybox doesn't support that syntax (see https://github.com/mirror/busybox/blob/master/procps/sysctl.c). However, it seems that at least HAOS uses the full sysctl, so for HAOS, this works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP15 barrier instruction emulation only exists on arm64 architecture. Avoid sysctl writing an error to the journal when the setting doesn't exist by prepending a dash.