Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash on creating automation from a server controlled iOS Action #2590

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Feb 19, 2024

Summary

When user tap on "Create automation" inside the action configuration screen the app was crashing because it was trying to save the action which was controlled server-side (created in yaml). This was fixed in this PR

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal self-assigned this Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (6c34210) 27.54% compared to head (2ba8a90) 27.12%.
Report is 4 commits behind head on master.

Files Patch % Lines
...es/App/Settings/SettingsDetailViewController.swift 0.00% 11 Missing ⚠️
Sources/App/Settings/ActionConfigurator.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2590      +/-   ##
==========================================
- Coverage   27.54%   27.12%   -0.43%     
==========================================
  Files         311      316       +5     
  Lines       31699    32198     +499     
==========================================
  Hits         8733     8733              
- Misses      22966    23465     +499     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal bgoncal merged commit f098b98 into master Feb 22, 2024
8 checks passed
@bgoncal bgoncal deleted the fix-crash-create-automation-server-action branch February 22, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant