Correct calls to subscription.async_unsubscribe_topics #19414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
OttoWinter
reviewed
Dec 17, 2018
|
We should add tests. |
3 tasks
|
Yeah this should have been caught by tests. Please include a test to test this. |
emontnemery
force-pushed
the
fix_async_unsubscribe_topics
branch
from
9d5d20f to
6d22d43
Compare
|
Test cases added. |
emontnemery
force-pushed
the
fix_async_unsubscribe_topics
branch
from
6d22d43 to
5aa5e1b
Compare
|
Cleared milestone as it does not cleanly apply to |
|
OK. Should I open a PR which does apply to |
|
Let's wait for 85, I can't do another hot fix or I'll go crazy. |
dshokouhi
pushed a commit
to dshokouhi/home-assistant
that referenced
this pull request
Dec 25, 2018
…t#19414) * Correct calls to subscription.async_unsubscribe_topics * Review comments * Add testcases
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix subscription.async_unsubscribe_topics to return the new (empty) subscription state
Also, when calling subscription.async_unsubscribe_topics, update the entity's subscription state
Background:
When Entity registry is called,
async_registry_updated(self, old, new)in helpers/entity.py is called.If
entity_idis changed, this will first remove, and then again add, the entity.Related issue (if applicable): fixes #19352
Checklist:
tox. Your PR cannot be merged unless tests pass