Miscellaneous ESPHome cleanups #19425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: esphome
platform: binary_sensor.esphome
small-pr
ghost
assigned
OttoWinter
commented
Dec 18, 2018
| @@ -60,4 +60,4 @@ def available(self): | |||
| """Return True if entity is available.""" | |||
| if self._static_info.is_status_binary_sensor: | |||
| return True | |||
| return super(EsphomeEntity, self).available | |||
| return super().available | |||
| 'binary_sensor', | ||
| 'cover', | ||
| 'fan', | ||
| 'light', | ||
| 'sensor', |
| @@ -461,6 +461,7 @@ def __init__(self, entry_id: str, component_key: str, key: int): | |||
| """Unregister callbacks.""" | |||
| for remove_callback in self._remove_callbacks: | |||
| remove_callback() | |||
| self._remove_callbacks = [] | |||
| @property | ||
| def assumed_state(self) -> bool: | ||
| """Return true if we do optimistic updates.""" | ||
| return self._static_info.optimistic |
There was a problem hiding this comment.
Switches can also be optimistic in ESPHome (for example template switches without a state lambda). Forgot to include it in the original PR.
MartinHjelmare
approved these changes
Dec 18, 2018
dshokouhi
pushed a commit
to dshokouhi/home-assistant
that referenced
this pull request
Dec 25, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
See comments
Checklist:
tox. Your PR cannot be merged unless tests pass