Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated BT Home Hub 5 Device Tracker Documentation #5964

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Updated BT Home Hub 5 Device Tracker Documentation #5964

merged 2 commits into from
Aug 9, 2018

Conversation

ahobsonsayers
Copy link
Contributor

Documentation updated to fit a pull request that is about to be closed:
home-assistant/core#15096

@ghost ghost added the to-do label Aug 6, 2018
@ahobsonsayers ahobsonsayers mentioned this pull request Aug 6, 2018
Merged
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch and removed to-do labels Aug 6, 2018
@frenck
Copy link
Member

frenck commented Aug 6, 2018

Looks like this PR is based off the current branch.
Please rebase onto the next branch.

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Aug 6, 2018
@frenck frenck added ready-for-review This PR needs to be reviewed has-parent This PR has a parent PR in a other repo and removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Aug 6, 2018
@frenck
Copy link
Member

frenck commented Aug 6, 2018

Rebased.

@frenck frenck self-assigned this Aug 6, 2018
@frenck
Copy link
Member

frenck commented Aug 6, 2018

✅ Approved. Thanks, @ahobsonsayers!
Can be merged as soon as the build passes (since the parent PR is merged already).

@frenck frenck merged commit cb4a971 into home-assistant:next Aug 9, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Aug 9, 2018
@frenck frenck removed their assignment Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahobsonsayers @frenck