Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sensor.snmp.markdown #5484

Merged
merged 3 commits into from
Sep 7, 2018
Merged

Update sensor.snmp.markdown #5484

merged 3 commits into from
Sep 7, 2018

Conversation

mtdcr
Copy link
Contributor

@mtdcr mtdcr commented Jun 2, 2018

Add options for SNMP v3.

Pull request in home-assistant: home-assistant/core#14753

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Jun 25, 2018
frenck
frenck previously approved these changes Jun 25, 2018
View reviewed changes
@frenck
Copy link
Member

frenck commented Jun 25, 2018

Thanks, @mtdcr! I've added some minor tweaks as well.
✅ Approved and can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR next This PR goes into the next branch has-parent This PR has a parent PR in a other repo labels Jun 28, 2018
@mtdcr mtdcr mentioned this pull request Jul 3, 2018
Merged
3 tasks
@stale
Copy link

stale bot commented Aug 27, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale The PR had no activity for quite some time, and is marked as Stale label Aug 27, 2018
@stale stale bot closed this Sep 3, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Sep 3, 2018
@fabaff fabaff reopened this Sep 7, 2018
@stale stale bot removed the Stale The PR had no activity for quite some time, and is marked as Stale label Sep 7, 2018
@ghost ghost assigned fabaff Sep 7, 2018
@ghost ghost added the ready-for-review This PR needs to be reviewed label Sep 7, 2018
fabaff
fabaff approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit c8f7e3f into home-assistant:next Sep 7, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@frenck frenck frenck left review comments

Assignees

@fabaff fabaff

Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtdcr @frenck @fabaff