-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add swing horizontal mode in mqtt climate docs #37710
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThis pull request adds new MQTT configuration attributes for HVAC integrations. It introduces command and state templates and topics for managing the swing horizontal mode, as well as a list of supported swing horizontal modes. The example configuration is updated to include these new attributes, enabling more granular control of the HVAC swing horizontal functionality via MQTT. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant MQTT_Integration
participant HVAC_Device
User->>MQTT_Integration: Request change to swing horizontal mode
MQTT_Integration->>HVAC_Device: Publish command (using swing_horizontal_mode_command_template & topic)
HVAC_Device-->>MQTT_Integration: Send state update (via swing_horizontal_mode_state_topic)
MQTT_Integration->>User: Update state (using swing_horizontal_mode_state_template)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Hey there @emontnemery, @jbouwh, @bdraco, mind taking a look at this feedback as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct the order to make it alphabetically correct
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
sorted alphabetically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thanks @mamrai1 👍
Can be merged when parent gets merged
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit