-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update govee-light-local docs #37112
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request updates the Govee Light Local integration documentation by expanding the list of supported device models. The changes include adding numerous Govee light model identifiers, ranging from H6069 to H805C. A new note has been included to advise users about potential scene compatibility limitations across different device models, recommending reporting of any model-specific issues to the library's issue tracker. Changes
This update appears to be a straightforward documentation enhancement to improve device compatibility information for the Govee Light Local integration. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/govee_light_local.markdown (1)
146-148
: Fix typo in the note section.There's a typo in the word "underling" (should be "underlying").
-Some scenes may not be supported from all devices. If you find a scene that's not working with a specific model, please open an issue at the [underling library](https://github.com/Galorhallen/govee-local-api/issues) +Some scenes may not be supported from all devices. If you find a scene that's not working with a specific model, please open an issue at the [underlying library](https://github.com/Galorhallen/govee-local-api/issues)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/govee_light_local.markdown
(3 hunks)
🔇 Additional comments (2)
source/_integrations/govee_light_local.markdown (2)
Line range hint
1-148
: Documentation structure looks good!The documentation follows Home Assistant's standards and provides clear information about the integration, including:
- Proper frontmatter
- Clear setup instructions
- External resource links
- Comprehensive device support list
- Important notes about compatibility
37-38
: Verify device models against the core PR.The device models have been added in alphanumeric order. Let's verify that these models match the supported devices in the parent PR.
Also applies to: 43-44, 49-50, 53-53, 55-57, 59-62, 68-69, 88-89, 92-92, 94-95, 97-101, 107-110, 115-115, 119-122, 126-126, 128-128, 130-144
✅ Verification successful
Models are correctly formatted and ordered
The device models H6069 and H606A are properly placed in alphanumeric order within the comprehensive list of supported models in the documentation.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Fetch and compare device models from the parent PR # Fetch the parent PR's changed files curl -s https://api.github.com/repos/home-assistant/core/pulls/136530/files | \ jq -r '.[].raw_url' | \ grep -i "govee" | \ xargs curl -s | \ grep -o 'H[0-9A-Z]\{4\}' | \ sort | \ uniqLength of output: 172
Script:
#!/bin/bash # Get all device models from the documentation echo "=== Models in documentation ===" cat source/_integrations/govee_light_local.markdown | grep -o 'H[0-9A-Z]\{4\}' | sort | uniq # Search for Govee-related files in the repository echo -e "\n=== Govee implementation files ===" fd -t f -e py govee # Try to find model definitions in Python files echo -e "\n=== Model definitions in code ===" rg -A 5 -B 5 "MODEL_" $(fd -t f -e py govee)Length of output: 1122
7d59823
to
179f4b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Galorhallen 👍
Proposed change
Update to the supported device list
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit