-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe confirmation options for button entities rows #35436
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Caution Review failedThe pull request is closed. 📝 Walkthrough📝 WalkthroughWalkthroughThe changes introduce a new optional configuration option called Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Button
participant ConfirmationDialog
User->>Button: Press button
Button->>ConfirmationDialog: Show confirmation dialog
ConfirmationDialog-->>User: Request confirmation
User->>ConfirmationDialog: Confirm action
ConfirmationDialog-->>Button: Execute action
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
source/_dashboards/entities.markdown (1)
118-121
: Consider adding an example demonstrating the confirmation option.While the documentation is clear, adding an example would help users understand how to implement this feature. You could add it to the "Examples" section, showing how to configure a confirmation dialog for a button entity.
Example suggestion:
type: entities entities: - entity: button.restart_server confirmation: text: Are you sure you want to restart the server? exemptions: - user: admin_user
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- source/_dashboards/entities.markdown (1 hunks)
🔇 Additional comments (1)
source/_dashboards/entities.markdown (1)
118-121
: LGTM! Configuration documentation is clear and well-structured.The new
confirmation
option is well-documented with clear description of its purpose and applicability. The cross-reference to detailed configuration options is appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @karwosts 👍
Proposed change
Describe feature implemented in home-assistant/frontend#21453
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
confirmation
option in the YAML configuration for entities, allowing users to add a confirmation dialog for button actions.confirmation
option, enhancing user understanding of its purpose and configuration.