-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[homematicip_cloud] Add set_home_cooling_mode service #33753
Conversation
Add documentation for set_cooling, refs home-assistant/core#121943
WalkthroughWalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomematicIPCloud as HomematicIP Cloud
User->>HomematicIPCloud: set_home_cooling_mode(enable)
HomematicIPCloud-->>User: Cooling enabled confirmation
User->>HomematicIPCloud: set_home_cooling_mode(disable)
HomematicIPCloud-->>User: Heating mode activated confirmation
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
source/_integrations/homematicip_cloud.markdown (1)
222-223
: Fix loose punctuation and add a blank line before the list.There is a loose punctuation mark and a missing blank line before the list.
- - `homematicip_cloud.set_cooling`: Enable or disable cooling for the home. + + - `homematicip_cloud.set_cooling`: Enable or disable cooling for the home.Tools
LanguageTool
[uncategorized] ~223-~223: Loose punctuation mark.
Context: ...ex. - -homematicip_cloud.set_cooling
: Enable or disable cooling for the home....(UNLIKELY_OPENING_PUNCTUATION)
Markdownlint
222-222: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @barryvdh 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
source/_integrations/homematicip_cloud.markdown (1)
222-222
: Fix loose punctuation and add a blank line before the list.There is a loose punctuation mark and a missing blank line before the list.
- - `homematicip_cloud.set_home_cooling_mode`: Enable or disable cooling for the home. + + - `homematicip_cloud.set_home_cooling_mode`: Enable or disable cooling for the home.Tools
LanguageTool
[uncategorized] ~222-~222: Loose punctuation mark.
Context: ...homematicip_cloud.set_home_cooling_mode`: Enable or disable cooling for the home....(UNLIKELY_OPENING_PUNCTUATION)
Co-authored-by: c0ffeeca7 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
source/_integrations/homematicip_cloud.markdown (2)
222-222
: Fix loose punctuation and add a blank line before the list.There is a loose punctuation mark and a missing blank line before the list.
- - `homematicip_cloud.set_home_cooling_mode`: Enable or disable cooling for the home. + + - `homematicip_cloud.set_home_cooling_mode`: Enable or disable cooling for the home.Tools
LanguageTool
[uncategorized] ~222-~222: Loose punctuation mark.
Context: ...homematicip_cloud.set_home_cooling_mode`: Enable or disable cooling for the home....(UNLIKELY_OPENING_PUNCTUATION)
322-331
: Use consistent action naming in YAML example.Ensure the action name in the YAML example is consistent with the service name.
- action: homematicip_cloud.set_home_cooling_mode + action: homematicip_cloud.set_home_cooling_mode
Add set_home_cooling_mode service, ref: home-assistant/core#121943
Proposed change
Document the new set_home_cooling_mode method for home-assistant/core#121943
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
homematicip_cloud
integration.