Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume flow rate device class #30748

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Volume flow rate device class #30748

merged 1 commit into from
Jan 30, 2024

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Jan 9, 2024

Proposed change

Add Volume flow rate device class

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 9, 2024
@home-assistant
Copy link

home-assistant bot commented Jan 9, 2024

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@elupus elupus changed the base branch from current to next January 9, 2024 19:11
@home-assistant home-assistant bot removed current This PR goes into the current branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 9, 2024
@home-assistant home-assistant bot added the next This PR goes into the next branch label Jan 9, 2024
@jbouwh jbouwh removed their request for review January 15, 2024 21:33
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged if the parent is merged

@joostlek joostlek added the awaits-parent Awaits the merge of an parent PR label Jan 25, 2024
@frenck frenck merged commit 040c85c into home-assistant:next Jan 30, 2024
6 checks passed
@home-assistant home-assistant bot removed awaits-parent Awaits the merge of an parent PR in-progress This PR/Issue is currently being worked on labels Jan 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants