Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed image_url information #30009

Merged
merged 3 commits into from
Nov 26, 2023
Merged

More detailed image_url information #30009

merged 3 commits into from
Nov 26, 2023

Conversation

hosebei
Copy link
Contributor

@hosebei hosebei commented Nov 26, 2023

As Discussed in home-assistant/core#90121, the usage of the image_url tends to be unclear. Added detailed information of the image_url string and requirements with link to teams cards documentation

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

As Discussed in home-assistant/core#90121, the usage of the image_url tends to be unclear.
Added detailed information of the image_url string and requirements with link to teams cards documentation
@home-assistant home-assistant bot added the current This PR goes into the current branch label Nov 26, 2023
source/_integrations/msteams.markdown Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 26, 2023 10:35
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@hosebei hosebei marked this pull request as ready for review November 26, 2023 12:10
@home-assistant home-assistant bot requested a review from frenck November 26, 2023 12:10
@frenck frenck marked this pull request as draft November 26, 2023 12:45
@frenck
Copy link
Member

frenck commented Nov 26, 2023

Put this PR back into draft, as the requested change / suggestion wasn't applied or responded on. Did you forgot to push a commit maybe @hosebei?

../Frenck

@hosebei
Copy link
Contributor Author

hosebei commented Nov 26, 2023

I'm very sorry, I thaught the buttons i pressed accepted you corrections and rerequested the merge.
I'm doing better.

@hosebei hosebei marked this pull request as ready for review November 26, 2023 13:28
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about it!

Thanks for the PR @hosebei 👍

../Frenck

@frenck frenck merged commit 5b08299 into home-assistant:current Nov 26, 2023
5 checks passed
@hosebei hosebei deleted the patch-1 branch November 26, 2023 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants