Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 'sentence-style capitalization' in HomeWizard #29879

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

DCSBL
Copy link
Contributor

@DCSBL DCSBL commented Nov 17, 2023

Proposed change

I just noticed #29861, which is a nice move. But it also changed "Energy Socket" to "Energy socket". In the context of HomeWizard, this should be kept as "Energy Socket" (a brand).

I would suggest to revert this, or: "HomeWizard Energy Socket" or "Controlling the state"?

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added current This PR goes into the current branch in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 17, 2023
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, @DCSBL 👍
I may have been a bit too trigger-happy on that one.

@c0ffeeca7 c0ffeeca7 merged commit 98538f4 into home-assistant:current Nov 17, 2023
6 checks passed
@home-assistant home-assistant bot removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 17, 2023
@DCSBL DCSBL deleted the patch-7 branch November 17, 2023 08:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants