Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify duration/end_date_time usage #29790

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

FletcherAU
Copy link
Contributor

Proposed change

Add a note to duration that it's mutually exclusive with end_date_time. (the latter of which already had this note)

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@FletcherAU FletcherAU requested a review from a team as a code owner November 10, 2023 16:09
@home-assistant home-assistant bot added the current This PR goes into the current branch label Nov 10, 2023
@FletcherAU FletcherAU marked this pull request as draft November 10, 2023 16:44
@c0ffeeca7
Copy link
Contributor

@FletcherAU, you marked this PR as draft a while ago. Is it ready for review? Or are you still working on it?

@FletcherAU
Copy link
Contributor Author

FletcherAU commented Nov 14, 2023

Ideally this change would include a clarification in the Optional column but I'm not sure whether that is in keeping with the standard set by other pages. I was holding off until there was clarification in either #29787 or #dev-documentation :)

source/_integrations/calendar.markdown Outdated Show resolved Hide resolved
source/_integrations/calendar.markdown Outdated Show resolved Hide resolved
@FletcherAU FletcherAU marked this pull request as ready for review November 14, 2023 08:46
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @FletcherAU 👍

@c0ffeeca7 c0ffeeca7 merged commit eef183c into home-assistant:current Nov 14, 2023
5 checks passed
@FletcherAU FletcherAU deleted the patch-4 branch November 14, 2023 08:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Incorrect details for service calendar.list_events
2 participants