Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded step from Google auth setup and clarify creation process #29784

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

FletcherAU
Copy link
Contributor

@FletcherAU FletcherAU commented Nov 10, 2023

Proposed change

The current steps cause the user to navigate to the create credential page earlier than required and then take them back there later.

I've also drawn attention to the criteria that will trigger a review process for the app (adding a logo) and what the consequences may be.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Nov 10, 2023
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @FletcherAU 👍

@c0ffeeca7 c0ffeeca7 merged commit 3c3a654 into home-assistant:current Nov 13, 2023
5 checks passed
@FletcherAU FletcherAU deleted the patch-2 branch November 13, 2023 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants