Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling of to-do list #29773

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Correct spelling of to-do list #29773

merged 3 commits into from
Nov 10, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Nov 9, 2023

Proposed change

Make sure we are consistent with how we write to-do lists.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@frenck frenck requested a review from a team as a code owner November 9, 2023 16:58
@home-assistant home-assistant bot added the current This PR goes into the current branch label Nov 9, 2023
source/_integrations/todo.markdown Outdated Show resolved Hide resolved
source/_integrations/todo.markdown Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 9, 2023 21:41
@home-assistant
Copy link

home-assistant bot commented Nov 9, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@frenck frenck marked this pull request as ready for review November 10, 2023 08:07
@MartinHjelmare
Copy link
Member

How will this solve the linked issue? Wasn't that case inverted compared to this change?

@frenck
Copy link
Member Author

frenck commented Nov 10, 2023

The spelling was inconsistent. It is now consistent with our user interface and according to the recommendations from the Microsoft Style Guide for writing (which we follow).

@MartinHjelmare
Copy link
Member

Ok. But the case style in the frontend is not consistent between the different items in the side bar.

@frenck
Copy link
Member Author

frenck commented Nov 10, 2023

CleanShot 2023-11-10 at 09 29 26@2x

This item in the frontend is correct, as in, follows sentence casing.

CleanShot 2023-11-10 at 09 30 16@2x

These seem to do so as well? What am I missing?

../Frenck

@MartinHjelmare
Copy link
Member

That looks good. The screenshot in the issue still had tools in Developer tools capitalized.

@frenck frenck merged commit a319e8d into current Nov 10, 2023
7 checks passed
@frenck frenck deleted the frenck-2023-1413 branch November 10, 2023 09:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Please rectify Type to follow menu
2 participants