Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nibe_heatpump.markdown #29740

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

grapefrukt
Copy link
Contributor

Fixes broken link to M12676EN document

Proposed change

Fixes expired link to the modbus documentation pdf

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Fixes broken link to M12676EN document
@grapefrukt grapefrukt requested a review from elupus as a code owner November 7, 2023 09:24
@home-assistant home-assistant bot added the current This PR goes into the current branch label Nov 7, 2023
@grapefrukt
Copy link
Contributor Author

Perhaps it would be better to not rely on NIBE to host this, but this seems to be the current url. I am not knowledgeable enough in the correct procedures for HA to discern where a suitable more permanent location for this file would be.

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @grapefrukt 👍

@c0ffeeca7 c0ffeeca7 merged commit 4a011b9 into home-assistant:current Nov 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants