Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event: Terminology tweak on button long-press #28403

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

c0ffeeca7
Copy link
Contributor

Proposed change

Event: Terminology tweak on button press

  • use long-press instead of press.... long
  • uses Apple SG in this case to fit in with Hue examples (as opposed to MS SG witch uses press and hold)

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Aug 2, 2023
@home-assistant
Copy link

home-assistant bot commented Aug 2, 2023

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @c0ffeeca7 👍

../Frenck

@frenck frenck added this to the 2023.8 milestone Aug 2, 2023
@frenck frenck merged commit 5bbf9b7 into next Aug 2, 2023
@frenck frenck deleted the long-press-button branch August 2, 2023 08:21
@home-assistant home-assistant bot removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Aug 2, 2023
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Aug 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-picked This PR has been manually picked and merged into the current branch next This PR goes into the next branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants