Fix event documentation example #28402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
in-progress
This comment was marked as outdated.
This comment was marked as outdated.
frenck
removed
in-progress
edenhaus
approved these changes
Aug 2, 2023
c0ffeeca7
reviewed
Aug 2, 2023
| @@ -43,7 +43,7 @@ Besides the timestamp of the last event, the event entity also keeps track of th | |||
|
|
|||
| This allows you, for example, to trigger a different action when the button on a remote control is pressed once or twice, if your remote control is capable of emitting these different types of events. | |||
|
|
|||
| When combining that with the [choose action](/docs/scripts/#choose-a-group-of-actions) script, you can assign multiple different actions to a single event entity. In the following example, pressing the button on the remote once or twice will trigger a different scene: | |||
| When combining that with the [choose action](/docs/scripts/#choose-a-group-of-actions) script, you can assign multiple different actions to a single event entity. In the following example, pressing the button on the remote short or long will trigger a different scene: | |||
There was a problem hiding this comment.
Suggested change
| When combining that with the [choose action](/docs/scripts/#choose-a-group-of-actions) script, you can assign multiple different actions to a single event entity. In the following example, pressing the button on the remote short or long will trigger a different scene: | |
| When combining that with the [choose action](/docs/scripts/#choose-a-group-of-actions) script, you can assign multiple different actions to a single event entity. In the following example, a different scene will be triggered depending on whether you press or press and hold the button: |
The MS Style Guide seems to use press and hold / select and hold
https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/p/press-and-hold
also google:
https://support.google.com/accessibility/android/answer/7650693?hl=en
Alternatively, Apple use the term long-press:
https://developer.apple.com/documentation/uikit/touches_presses_and_gestures/handling_uikit_gestures/handling_long-press_gestures
There was a problem hiding this comment.
Not in this case, as it is a physical remote, and not an UI button.
As per Microsoft:
This is a hardware button, so matches the guides.
| sequence: | ||
| - scene: scene.living_room_evening | ||
| - conditions: | ||
| - alias: "Move" | ||
| - alias: "Scene for watching a movie if the button was pressed long" |
There was a problem hiding this comment.
Suggested change
| - alias: "Scene for watching a movie if the button was pressed long" | |
| - alias: "Scene for watching a movie if the button was pressed and held" |
There was a problem hiding this comment.
This is matching the Hue wording, that is used in the example.
frenck
added
the
cherry-picked
frenck
added a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adjusts/fixes the event button example, as reported by @Petro31 on Discord in the #beta channel.
It also changes the event types, as at the time of writing, the Hue events didn't exist yet. Now they do, and Hue doesn't have a double press 😅
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.