Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bluetooth adapters #24865

Merged
merged 45 commits into from
Nov 16, 2022
Merged

Update Bluetooth adapters #24865

merged 45 commits into from
Nov 16, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 8, 2022 •
edited
Loading

Proposed change

Now that I know what to look for when ordering these, I found
quite a few more of the better performing ones as the quality
of the Linux driver seems to be the most important factor.

Another pile of adapters arrived today so I'm updating
the docs again.

Document the slow startup of the Broadcom adapters
on the Odroid n2+

Document the lack of reset pin on the RTLs

The test box has grown to two test boxes:
IMG_0068

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

bdraco added 2 commits November 8, 2022 15:35
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
1f06e7a 
Now that I know what to look for when ordering these, I found
quite a few more
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
577524b 
Now that I know what to look for when ordering these, I found
quite a few more
@home-assistant home-assistant bot added the current This PR goes into the current branch label Nov 8, 2022
bdraco added 13 commits November 8, 2022 15:43
@bdraco
tweaks
ebeda1b
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
d43a862 
Now that I know what to look for when ordering these, I found
quite a few more
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
35d0da2 
Now that I know what to look for when ordering these, I found
quite a few more
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
9e730a4 
Now that I know what to look for when ordering these, I found
quite a few more
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
1b79595 
Now that I know what to look for when ordering these, I found
quite a few more
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
379d85f 
Now that I know what to look for when ordering these, I found
quite a few more
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
a983dae 
Now that I know what to look for when ordering these, I found
quite a few more
@bdraco
tweaks
8a6e067
@bdraco
tweaks
3fa9d18
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
c32b769 
Now that I know what to look for when ordering these, I found
quite a few more
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
1bfa81e 
Now that I know what to look for when ordering these, I found
quite a few more
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
9ffcca6 
Now that I know what to look for when ordering these, I found
quite a few more
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
0aac585 
Now that I know what to look for when ordering these, I found
quite a few more
@bdraco bdraco changed the title Add additional Bluetooth adpaters Update Bluetooth adapters and document problem with Broadcom patch files Nov 8, 2022
@bdraco bdraco changed the title Update Bluetooth adapters and document problem with Broadcom patch files Update Bluetooth adapters and document expected slow startup Broadcom patch files Nov 8, 2022
@bdraco bdraco changed the title Update Bluetooth adapters and document expected slow startup Broadcom patch files Update Bluetooth adapters and document expected slow startup with missing Broadcom patch files Nov 8, 2022
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
6976ee6 
Now that I know what to look for when ordering these, I found
quite a few more
@bdraco bdraco marked this pull request as ready for review November 8, 2022 23:25
@bdraco
Add additional Bluetooth adpaters that pass high performance testing
9fbc1a2 
Now that I know what to look for when ordering these, I found
quite a few more
@bdraco bdraco mentioned this pull request Nov 9, 2022
Open
@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 15, 2022
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@bdraco bdraco removed in-progress This PR/Issue is currently being worked on has-parent This PR has a parent PR in a other repo needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 15, 2022
@bdraco bdraco changed the title Update Bluetooth adapters and document expected slow startup with missing Broadcom patch files Update Bluetooth adapters Nov 16, 2022
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 16, 2022
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@home-assistant home-assistant bot removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Nov 16, 2022
@bdraco bdraco removed in-progress This PR/Issue is currently being worked on has-parent This PR has a parent PR in a other repo labels Nov 16, 2022
frenck
frenck approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @bdraco 👍

@frenck frenck merged commit c22ce2a into current Nov 16, 2022
@frenck frenck deleted the more_bluetooth branch November 16, 2022 21:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @frenck