Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elmax/cover #24308

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Elmax/cover #24308

merged 3 commits into from
Aug 5, 2023

Conversation

albertogeniola
Copy link
Contributor

Proposed change

Declaring alarm_control_panel and cover platforms support.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@homeassistant homeassistant added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Oct 1, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unrelated commits in this PR. Please git rebase your changes onto the latest upstream next branch in order to clean that up.

Thanks 👍

../Frenck

@frenck frenck added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Oct 10, 2022
@albertogeniola
Copy link
Contributor Author

There are unrelated commits in this PR. Please git rebase your changes onto the latest upstream next branch in order to clean that up.

Thanks 👍

../Frenck

Should be fine now @frenck! Sorry for having included that commit.
Can you confirm it's all in place and merge please?

Thanks!

@frenck
Copy link
Member

frenck commented Jan 6, 2023

and merge please?

That is not possible, as it depends on an upstream change in the core codebase (the cover platform isn't merged).

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Jan 6, 2023
@xGeKox
Copy link

xGeKox commented Feb 15, 2023

Hi guys. Update for implementation?

@frenck frenck removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Mar 17, 2023
@xGeKox
Copy link

xGeKox commented Aug 5, 2023

Any updates?

@gjohansson-ST gjohansson-ST merged commit c034624 into home-assistant:next Aug 5, 2023
@home-assistant home-assistant bot removed the awaits-parent Awaits the merge of an parent PR label Aug 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! hacktoberfest-accepted has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants