Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new component renault documentation #14383

Merged
merged 5 commits into from
Aug 5, 2021
Merged

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Sep 3, 2020

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Sep 3, 2020
@probot-home-assistant probot-home-assistant bot added the next This PR goes into the next branch label Sep 3, 2020
@epenet epenet marked this pull request as ready for review September 3, 2020 09:07
@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration and removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Sep 3, 2020
@epenet
Copy link
Contributor Author

epenet commented Sep 4, 2020

@frenck you asked on the main PR that I remove the extra platforms (binary_sensor, climate, device tracker) for the new integration, and follow up with subsequent PRs.
For the documentation is it best to keep in sync with the main PR, or set the documentation PR as we hope it will be when all the subsequent PRs are merged?

@frenck
Copy link
Member

frenck commented Sep 4, 2020

The documentation must match the linked PR

frenck
frenck previously approved these changes Sep 4, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Sep 4, 2020
@epenet
Copy link
Contributor Author

epenet commented Sep 7, 2020

Hi @frenck,

Following the discussions on the main PR, I have amended the documentation with a link to the instructions on how to grab the API keys from the Renault servers.

@epenet epenet requested a review from frenck September 24, 2020 09:37
frenck
frenck previously approved these changes Oct 20, 2020
Copy link
Contributor

@milanmeu milanmeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck Parent merged.
This should be merged to the current branch because the integration is already available in 2021.8.

@frenck frenck modified the milestone: 2021.8.0 Aug 5, 2021
@frenck frenck changed the base branch from next to current August 5, 2021 06:31
@frenck frenck dismissed their stale review August 5, 2021 06:31

The base branch was changed.

@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Aug 5, 2021
@probot-home-assistant probot-home-assistant bot added current This PR goes into the current branch and removed next This PR goes into the next branch labels Aug 5, 2021
@probot-home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.
(message by DocsTargetBranch)

@frenck frenck merged commit 1c2642e into home-assistant:current Aug 5, 2021
@probot-home-assistant probot-home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on awaits-parent Awaits the merge of an parent PR labels Aug 5, 2021
raman325 pushed a commit to raman325/home-assistant.io that referenced this pull request Aug 10, 2021
@epenet epenet deleted the renault branch August 17, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed current This PR goes into the current branch has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants