Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home connect #13350

Merged
merged 2 commits into from
May 8, 2020
Merged

Home connect #13350

merged 2 commits into from
May 8, 2020

Conversation

DavidMStraub
Copy link
Contributor

Hi @frenck, thanks for merging my PR #11336! However since it is already a couple of months old, I realized that a few minor things that were changed during the PR discussion in the Core repo need to be changed:

  • The integration was renamed to homeconnect to home_connect
  • The attributes of the power switch have been removed
  • The elapsed time sensor has been removed
  • The remaining time sensor has been converted to a timestamp sensor.

This PR reflects these changes in the docs.

@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 8, 2020
@probot-home-assistant probot-home-assistant bot added the next This PR goes into the next branch label May 8, 2020
frenck
frenck approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @DavidMStraub 👍

@frenck frenck removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 8, 2020
@frenck frenck merged commit 07572d5 into home-assistant:next May 8, 2020
@probot-home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.
(message by DocsTargetBranch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees

@DavidMStraub DavidMStraub

Labels
next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidMStraub @frenck