-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to support config entries #10467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, @shred86!
I've left some comments, could you take a look? Thanks! 👍
I've rebased this on my local branch but when I try to
Edit: Just tried deleting my local repo completely and starting over. Cloned a copy of my GitHub fork and rebased. Still getting the same error. Been trying to resolve this for a couple hours - may be easier to just delete this PR and start over. |
@shred86 I'll rebase this PR for you, hold on ⏳ |
Any luck with the rebase? Hopefully I didn't completely screw this PR up. ;( I do have one minor update to the documentation though once it's rebased. |
Sets `ha_config_flow` to `true` and added some additional instructions to the configurations section. This is tied to the following pull request: home-assistant/core#26699
The 'exclude', 'light' & 'name' configuration variables are no longer used in the abode component.
Co-Authored-By: Franck Nijhof <[email protected]>
Co-Authored-By: Franck Nijhof <[email protected]>
Co-Authored-By: Franck Nijhof <[email protected]>
@shred86 Rebased and resolved all merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
Description:
Sets
ha_config_flow
totrue
and added some additional instructions to the configurations section.Pull request in home-assistant (if applicable): home-assistant/core#26699
Checklist:
next
is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent
.