Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation section to README #402

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Add installation section to README #402

merged 1 commit into from
Jul 31, 2023

Conversation

bokub
Copy link
Contributor

@bokub bokub commented Jul 30, 2023

There is no badge or link to the npm page, which is really confusing (I was wondering if it was actually published on npm or not).

I added a section to the README to remove this possible confusion. It's very standard for npm packages to have this section.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to run prettier?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft July 30, 2023 17:29
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@bokub
Copy link
Contributor Author

bokub commented Jul 30, 2023

You're right, I made that change directly from the GitHub edition mode so I didn't run prettier.

Should be OK now

image

@bokub bokub requested a review from frenck July 30, 2023 18:43
@bokub bokub marked this pull request as ready for review July 30, 2023 18:43
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bokub 👍

../Frenck

@frenck frenck merged commit c8c0c85 into home-assistant:master Jul 31, 2023
@bokub bokub deleted the patch-1 branch July 31, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants