Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing entity attributes #251

Merged
merged 3 commits into from
Mar 12, 2022
Merged

Fix removing entity attributes #251

merged 3 commits into from
Mar 12, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 12, 2022

  • The attributes to remove is list

  • Avoid a copy of attributes when both adding and removing

balloob
balloob reviewed Mar 12, 2022
View reviewed changes
lib/entities.ts Outdated Show resolved Hide resolved
@balloob balloob merged commit 99b54f4 into home-assistant:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdraco @balloob @homeassistant