Add optional parameter to subscribeMessage to stop resubscription on reconnect #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jul 31, 2020
balloob
reviewed
Jul 31, 2020
Co-authored-by: Paulus Schoutsen <[email protected]>
balloob
reviewed
Aug 1, 2020
README.md
Outdated
| @@ -363,13 +363,13 @@ Listen for events on the connection. [See docs.](#automatic-reconnecting) | |||
|
|
|||
| Send a message to the server. Returns a promise that resolves or rejects based on the result of the server. Special case rejection is `ERR_CONNECTION_LOST` if the connection is lost while the command is in progress. | |||
|
|
|||
| ##### `conn.subscribeMessage(callback, subscribeMessage)` | |||
| ##### `conn.subscribeMessage(callback, subscribeMessage[, resubscribe = true])` | |||
balloob
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional parameter to the
subscribeMessageto be able to set whether or not to re-establish the subscription after a reconnect.Fixes: #130