Fix memory leak in unsubscribe while disconnected (#127)

home-assistant · Jun 26, 2020 · e48d529 · e48d529
1 parent 347ff4b
commit e48d529
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/connection.ts b/lib/connection.ts
@@ -297,10 +297,11 @@ export class Connection {
         subscribe: () => this.subscribeMessage(callback, subscribeMessage),
         unsubscribe: async () => {
           // No need to unsubscribe if we're disconnected
-          if (!this.connected) {
-            return;
+          if (this.connected) {
+            await this.sendMessagePromise(
+              messages.unsubscribeEvents(commandId)
+            );
           }
-          await this.sendMessagePromise(messages.unsubscribeEvents(commandId));
           this.commands.delete(commandId);
         },
       };