Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice assistants config: Filter unavailable assists #23637

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

wendevlin
Copy link
Contributor

Proposed change

  • if an assists is unvailable it doesn't count to the number of assist devices, so it is consistent with the devices shown in the assist devices table

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@wendevlin wendevlin added this to the 2025.1 milestone Jan 8, 2025
@MindFreeze MindFreeze merged commit c6aec2d into dev Jan 8, 2025
16 checks passed
@MindFreeze MindFreeze deleted the fix-num-assists branch January 8, 2025 15:22
bramkragten pushed a commit that referenced this pull request Jan 9, 2025
Filter unavailable assists from num of assist devices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants