Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customize mode option to card features with modes #20670

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Apr 30, 2024

Proposed change

Following #20647. This PR add a customize mode option in the UI for every feature with modes.

CleanShot.2024-04-29.at.09.19.33.mp4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya marked this pull request as ready for review April 30, 2024 08:04
Copy link
Contributor

@karwosts karwosts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks!

@piitaya piitaya merged commit 7120ad9 into dev Apr 30, 2024
13 checks passed
@piitaya piitaya deleted the customize_modes_card_feature branch April 30, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants