Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unlock icon for tile card lock features #20667

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

krazos
Copy link
Contributor

@krazos krazos commented Apr 29, 2024

Proposed change

In PR#116157 (core), the icon for an unlocked lock was recently changed from mdi:lock-open to mdi:lock-open-variant to make it easier to visually distinguish between locked and unlocked states:

image

I propose to make the same change to the unlock button in the newly-added tile card lock features for the same reason and in the interest of consistency across the UI.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

type: tile
entity: lock.front_door
features:
  - type: lock-commands

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Update unlock icon for tile card lock features so it's easier to see the difference between lock and unlock buttons
@silamon silamon added this to the 2024.5 milestone Apr 29, 2024
@silamon silamon merged commit 8cca233 into home-assistant:dev Apr 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants