-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uncompressed files from bundles and compress source maps #19838
Conversation
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
This change is unblocked by |
home-assistant/core#123166 will unblock this. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Proposed change
Start compressing source maps and removed the uncompressed files to reduce the build/wheel to a more cache-friendly and faster downloading size. The uncompressed versions are useless to the vast majority of users. Discussion at home-assistant/architecture#976.
This won't work yet so is draft for now. Core change is required to provide decompressed versions and/or adjust
aiohttp
handler not to respond with 404s.Here's a nightly run on this branch. Wheel size is 30MB vs 50MB.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: