Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for color temperature tile feature #16515

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Added support for color temperature tile feature #16515

merged 2 commits into from
Aug 17, 2023

Conversation

PaoloTK
Copy link
Contributor

@PaoloTK PaoloTK commented May 11, 2023

Proposed change

The color temperature tile feature has been added for lights that support CCT control.
chrome_Ysk1iY4zfE
chrome_8Xg8kTDezP

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

type: tile
entity: light.ceiling_lights
features:
  - type: light-color-temp

Additional information

Something to discuss about the current features implementation is the inability to see the current value for the feature. With brightness being the only stock feature right now this is not a problem, because the brightness percentage is listed under the entity name. We could add dynamic text based on the features enabled for the card? But if a lot of features are added I think it would be verbose. An idea I had was to flash for a few seconds the value set in the feature in place of the current brightness percentage for lights. For example this is what the card would look like after setting the picker for the color temperature:
chrome_f2HtGL4b9d

Thoughts?

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@william-sy

This comment was marked as off-topic.

@frenck
Copy link
Member

frenck commented Jul 20, 2023

@william-sy Please don't do that. Thanks 👍

@github-actions github-actions bot added the Design Related to Home Assistant design gallery label Aug 17, 2023
@piitaya
Copy link
Member

piitaya commented Aug 17, 2023

We can merge it without changing the displayed state. For now, user can go to the more info to see the kelvin value.
I agree, we should have a way to visualize the kelvin value when dragging. We also have the same issue with the brightness when dragging.

Also, there is another discussion about letting the user choose what to display as state #16661.

I will look if we can improve the gradient by using the min and max kelvin values like we have in the more info light.

@piitaya piitaya merged commit 6584dc7 into home-assistant:dev Aug 17, 2023
@PaoloTK
Copy link
Contributor Author

PaoloTK commented Aug 17, 2023

We can merge it without changing the displayed state. For now, user can go to the more info to see the kelvin value. I agree, we should have a way to visualize the kelvin value when dragging. We also have the same issue with the brightness when dragging.

Also, there is another discussion about letting the user choose what to display as state #16661.

I will look if we can improve the gradient by using the min and max kelvin values like we have in the more info light.

Fair enough, thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Design Related to Home Assistant design gallery Tile card
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants