Fix intermittent unable to s6_svstatus_read error
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frenck would you mind taking a look at this? |
19 tasks
pvizeli
approved these changes
Nov 24, 2022
frenck
reviewed
Nov 24, 2022
|
Continuing the conversation from home-assistant/core#82527 (comment) (the issue got locked): s6-overlay has increased the default value of the variable to 50 by default: just-containers/s6-overlay@40f5794 (based on just-containers/s6-overlay#460 (comment)). When the next version of it is released, we can upgrade and remove this line from the base image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this issue in both HA core and any addon, intermittently, so I believe it's safe to add this by default in the base images.
The default value is 5 (milliseconds), and I increased to 50 milliseconds. This should be more than enough to iron out the issue even in the worst scenario, while the additional 45 ms makes absolutely no difference for the HA use case (in my opinion).
@frenck I plan to send the same PR for the community addons base images as well, as I have noticed this issue to happen in the Asterisk addon, which extends from the Debian community addon base.