Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.9.1 #99950

Merged
merged 35 commits into from
Sep 8, 2023
Merged

2023.9.1 #99950

merged 35 commits into from
Sep 8, 2023

Conversation

bramkragten
Copy link
Member

No description provided.

dknowles2 and others added 30 commits September 8, 2023 19:59
* Handle temp adjust when target state not set

* Update homeassistant/components/alexa/errors.py

Co-authored-by: Robert Resch <[email protected]>

* black

---------

Co-authored-by: Robert Resch <[email protected]>
* Fix Freebox disk free space sensor

* Add initial value assert to check results
* Bump pyenphase to 1.9.2

changelog: pyenphase/pyenphase@v1.9.1...v1.9.2

Handle the case where the user has manually specified a password for
local auth with firmware < 7.x but its incorrect.

The integration previously accepted any wrong password and would
reduce functionality down to what works without a password. We now
preserve that behavior to avoid breaking existing installs.

* bump
* Bump pylutron-caseta to v0.18.2

Minor bump to pylutron-caseta requirement to support wall mounted occupancy sensor device type in latest RA3 firmware.

* Update requirements_all.txt for pylutron-caseta 0.18.2

* Update requirements_test_all.txt for pylutron-caseta 0.18.2
* Fix missing dew point and humidity in tomorrowio forecasts

* Add assertion for correct parameters to realtime_and_all_forecasts method
* bump aiovodafone to 0.1.0

* fix tests
Bump pymodbus v3.5.0.
* Bump zeroconf to 0.92.0

changelog: python-zeroconf/python-zeroconf@0.91.1...0.92.0

* drop unused argument

* Update tests/components/thread/test_diagnostics.py

* lint

* again

* bump again since actions failed to release the wheels
@home-assistant home-assistant bot added cla-signed core merging-to-master This PR is merging into the master branch and should probably change the branch to `dev`. labels Sep 8, 2023
Update Mill lib

Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
@@ -13,7 +13,7 @@
"integration_type": "hub",
"iot_class": "cloud_polling",
"loggers": ["boto3", "botocore", "pyhumps", "pyoverkiz", "s3transfer"],
"requirements": ["pyoverkiz==1.10.1"],
"requirements": ["pyoverkiz==1.9.0"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~~
Revert this change.

As 2023.9.0 made an unwanted breaking change (see) and .1 did not revert the revert made for .0 (see #99741 (review)) we should now let it like that.

To fix the unique_id breaking change, see #99765.

With that, I request changes.
~~

Changed my mind:
This line will fix the issue #99404
Then the unique_id breaking change will be limited to 2023.9.0 only.
So people upgrading from <= 2023.8.x to 2023.9.1 won't have breaking change.

I don't know if it's nice doing like that.

I didn't dare block (request change) the merge for 2023.9.0 but maybe I should have.

With that, I approve.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just add an alert to prevent users for 2023.9.0 breaking change and advice to skip .0 and go directly to 2023.9.1+ !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen for people going from 2023.9.0 to 23023.9.1 then now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted by Discord:

Getting their ID back from before 2023.9.0

Going from <= 2023.8.x to >= 2023.9.1 won't notice any issue.

Not sure but maybe people that upgraded to 2023.9.0 that did not customize anything to the entity aren't also concerned.

Thanks for the merge 🥳
So now the breaking change only concerns certain persons on 2023.9.0 only !

@bramkragten bramkragten merged commit 9e6ac1d into master Sep 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core merging-to-master This PR is merging into the master branch and should probably change the branch to `dev`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.