-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unifi add port forward control to switch platform #98309
Unifi add port forward control to switch platform #98309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kane610 you probably know better than me, but shouldn't aiounifi
be upgraded first and after that add the port forward control functionality in a different PR?
This is typically how at least I've done it since forever. The only changes for the library is for port forward control :) |
Ok, no problem then :) |
Kane610/aiounifi@v53...v54#diff-337a9fb8934de299dd2b73f984e86594251476b3de9893e4b777d9e1a772e8e2R245 |
No it shouldn't... I've removed it in the following library release Kane610/aiounifi@v54...v55 which will be brought in by #98549 |
388b2ea
to
fd8afab
Compare
#98549 has been merged so no issue with the stale print in the library anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Kane610 👍
../Frenck
Awesome! Thank you @frenck 🎉 |
Breaking change
Proposed change
Allow controlling port forwarding in UniFi
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: