-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to sort options in select selector #97680
Conversation
Thanks for the test fix @frenck. Missed that one 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😀
Thanks, @farmio ❤️ PS: Something to consider for the selectors: Should the options be sorted? (regardless of translation). |
The options source list is already sorted 😉
|
Aah right, in that case: It doesn't add much 👍 Thanks for clarifying that! ../Frenck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @piitaya 👍
../Frenck
Proposed change
Options will be sorted alphabetically with this parameter.
Related Frontend PR : home-assistant/frontend#17468
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: