Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump melnor-bluetooth to fix deadlock #94098

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

vanstinator
Copy link
Contributor

@vanstinator vanstinator commented Jun 6, 2023

Proposed change

Bumps the melnor-bluetooth library to 0.0.24, which fixes an infinite loop that ends up deadlocking the python event loop. There was a case I wasn't handling properly that only manifested itself when a valve was fresh from the factory without having been connected to even the manufacturers mobile app yet. Happened across it while testing a different valve on the beta that I'd purchased to verify an upcoming virtual_brand.

This is an issue in the current beta, and needs to land before the release on Wednesday.

This kids, is why you don't use while loops after 9pm on a weeknight (or ever, unless necessary)
vanstinator/melnor-bluetooth@v0.0.22...v0.0.24

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@balloob balloob added this to the 2023.6.0 milestone Jun 6, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while true; echo ✅ Thanks for the PR!; done.

../Frenck

@frenck frenck merged commit 0b88059 into home-assistant:dev Jun 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants