fix: Bump melnor-bluetooth to fix deadlock #94098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Bumps the melnor-bluetooth library to
0.0.24
, which fixes an infinite loop that ends up deadlocking the python event loop. There was a case I wasn't handling properly that only manifested itself when a valve was fresh from the factory without having been connected to even the manufacturers mobile app yet. Happened across it while testing a different valve on the beta that I'd purchased to verify an upcomingvirtual_brand
.This is an issue in the current beta, and needs to land before the release on Wednesday.
This kids, is why you don't use
while
loops after 9pm on a weeknight (or ever, unless necessary)vanstinator/melnor-bluetooth@v0.0.22...v0.0.24
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: