Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add Roborock switches if it is not supported #94069

Merged
merged 5 commits into from
Jun 5, 2023
Merged

Don't add Roborock switches if it is not supported #94069

merged 5 commits into from
Jun 5, 2023

Conversation

Lash-L
Copy link
Contributor

@Lash-L Lash-L commented Jun 5, 2023 •
edited
Loading

Breaking change

Proposed change

Roborock devices return 'unknown_method' if the command is not supported. in the most recent bump, that is now an exception that is thrown(and caught by the send method in device.py and raises HomeAssistantError)

So if a HomeAssistantError is raised, we should avoid adding this entity.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jun 5, 2023

Hey there @humbertogontijo, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@Lash-L Lash-L mentioned this pull request Jun 5, 2023
Closed
@balloob balloob added this to the 2023.6.0 milestone Jun 5, 2023
@MartinHjelmare MartinHjelmare changed the title don't add Roborock switches if it is not supported Don't add Roborock switches if it is not supported Jun 5, 2023
@Lash-L
Copy link
Contributor Author

Lash-L commented Jun 5, 2023

Will that patch coverage be an issue? Can't think of a good way of just patching send command to test for one argument that gets called in this specific test without creating a new fixture. Which I could do - but it seems ineffective.

@balloob balloob merged commit e30e423 into home-assistant:dev Jun 5, 2023
balloob pushed a commit that referenced this pull request Jun 5, 2023
@Lash-L @balloob
Don't add Roborock switches if it is not supported (#94069)
4bb6fec 
* don't add switches if it is not supported

* don't create entity unless if it is valid

* Raise on other exceptions

* rework valid_enties
@Lash-L
Copy link
Contributor Author

Lash-L commented Jun 5, 2023 •
edited
Loading

This was on top of the version bump done in #94035 - I don't think anything will inherently be broken - but I assumed the version bump would be included in the beta release as well. The Exception being raised for an unknown method was added in the version bump, without it, I don't think this actually will fix anything

That is my bad, I should have realized the milestone wasn't on the version bump

@luca-angemi
Copy link
Contributor

Correct. I've update HA but the issue persists.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: roborock Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.6.0
Development

Successfully merging this pull request may close these issues.

Roborock throws error while setting up
4 participants
@Lash-L @luca-angemi @balloob @MartinHjelmare