-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package names to match pypi index metadata #93883
Conversation
FWIW: I though about |
OR we could also modify pip to fetch the metadata concurrently. That is a huge bottleneck ATM with so many dependencies. |
The big bottleneck we have right now is find links since it’s doing a full search over all the links on wheels once per package. With the index it does t haven’t to do that anymore
That would also help a lot |
index-503
also needs to rewrite the metadata for all the requires it builds to fix the inconsistent names to make pip happy, but that will happen outside of this repo.Proposed change
To improve the resolution time with the new resolver, we can use
--extra-index-url
by building a PEP 503 index with https://github.com/bdraco/index-503. For this to work the package names must match the metadata as pip is strict about this and will ignore the package otherwise.If all packages have their names correct we could use
--index-url
and no extra which would make it even faster but some of our deps have the wrong names as well:To test
pip3 install --dry-run --only-binary=:all: --extra-index-url "https://wheels.koston.org/musllinux-index/" -r requirements_and.txt
merged requirements file built at the time the snapshot of wheels.koston.org/musllinux was made from wheels.home-assistant.io that has been modified from this PR
requirements_and.txt
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: