Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scan interval to Command Line #93752

Merged
merged 7 commits into from
Jun 3, 2023

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented May 29, 2023

Proposed change

Add scan interval option to Command Line (lost when moving to integration key YAML)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@gjohansson-ST gjohansson-ST force-pushed the cmd_line_scan_interval branch from dac53b2 to 7601c54 Compare May 29, 2023 19:55
@frenck frenck added this to the 2023.6.0 milestone Jun 1, 2023
@emontnemery emontnemery marked this pull request as draft June 1, 2023 09:32
@gjohansson-ST gjohansson-ST marked this pull request as ready for review June 2, 2023 15:23
@balloob balloob merged commit 038b0e6 into home-assistant:dev Jun 3, 2023
balloob pushed a commit that referenced this pull request Jun 3, 2023
* Add scan interval

* Handle previous not complete

* Fix faulty text

* Add tests

* lingering

* Cool down

* Fix tests
@parautenbach
Copy link

I thought there was a move away from any sensor having a configurable scan interval. I understood the directive to be:

  • There's a default built-in of 30 sec.
  • Via the UI you can only turn it on or off.
  • If off, you customise it using an automation.

I mean, I don't really care. I just remember massive debates when the team started to remove this, so it's strange to see a change where it's added again for an integration.

@gjohansson-ST gjohansson-ST deleted the cmd_line_scan_interval branch June 3, 2023 06:31
@gjohansson-ST
Copy link
Member Author

  • Via the UI you can only turn it on or off.

It's not UI based

@balloob
Copy link
Member

balloob commented Jun 4, 2023

@parautenbach you are correct for UI-based integrations. Command-line is not UI-based as it allows arbitrary command execution.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

command_line sensor SCAN_INTERVAL support
5 participants